feat(course-registry): add unenroll and is_enrolled - #73
Open
Degentle12 wants to merge 1 commit into
Open
Conversation
- Add Unenrolled contractevent with learner and course_id topics - Add unenroll(env, learner, id) to remove a learner progress record Panics: "Not enrolled", "Already completed", "Course not found" - Add is_enrolled(env, learner, id) -> bool view helper - Add 13 unit tests: success, storage removal, events, re-enrollment, completed-course panic, excess-progress panic, unauthorized access, and is_enrolled across all enrollment states Closes Kqirox#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
course-registry::enrollwritesDataKey::Progress(learner, id) = 0u32but provides no inverse. A learner who enrolls by mistake is permanently enrolled —enrollpanics with "Learner already enrolled" on retry — and the progress record persists in storage forever.Solution
unenroll(env, learner, id)— Removes the learner's progress record from storage. Learner-authorized. Panics with"Not enrolled"if no record exists and"Already completed"for finished courses (completion is irreversible).is_enrolled(env, learner, id) -> bool— View helper returning true if a progress record exists.Unenrolledcontract event emitted on successful unenrollment.is_enrolledstates.Closes #17