feat(course-registry): add enroll_many batch enrollment operation - #74
Open
Degentle12 wants to merge 1 commit into
Open
feat(course-registry): add enroll_many batch enrollment operation#74Degentle12 wants to merge 1 commit into
Degentle12 wants to merge 1 commit into
Conversation
- Add enroll_many(env, admin, learners, id) -> Vec<bool> for cohort onboarding - Admin-authorized batch enrollment that does not abort on partial failure - Returns true for each newly-enrolled learner, false for already-enrolled - Validates course exists and is active before enrolling each learner - Add 7 unit tests: success, partial duplicates, empty vec, all-already-enrolled, unauthorized admin, nonexistent course, and inactive course scenarios Closes Kqirox#31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Course-registry has only single-learner enrollment. A 100-learner cohort onboarding requires 100 separate transactions.
Solution
enroll_many(env, admin, learners: Vec<Address>, id) -> Vec<bool>— Admin-authorized batch enrollment for cohort onboarding.truefor each newly-enrolled learner,falsefor already-enrolled (skipped).Closes #31