strip double quote in path #3
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThe PR updates the makefile generator's Absolutify method to strip enclosing double quotes from paths returned by node -p on MINGW, preventing incorrect path handling. Class diagram for updated Absolutify method in Makefile generatorclassDiagram
class MakefileGenerator {
+Pchify(path, lang)
+Absolutify(path)
}
MakefileGenerator : Absolutify(path)
MakefileGenerator : "path = path.strip('"')" // new line added to strip double quotes
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Summary of ChangesHello @lsq, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the robustness of path handling within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where paths returned by node -p on MINGW may be enclosed in double quotes. The change correctly strips these quotes in the Absolutify method. My feedback focuses on improving the code style of the comment explaining this change to align with Python best practices.
| """In MINGW node -p return a path with double quote""" | ||
| path = path.strip('"') |
There was a problem hiding this comment.
This string literal acts as a comment, but it's better to use a standard hash (#) comment for clarity and to follow Python conventions. String literals that are not docstrings or assigned to variables are evaluated and then discarded, which can be slightly less efficient and might be confusing to other developers. I've also slightly rephrased the comment for clarity.
| """In MINGW node -p return a path with double quote""" | |
| path = path.strip('"') | |
| # In MINGW, `node -p` can return a path enclosed in double quotes. | |
| path = path.strip('"') |
| """Convert a subdirectory-relative path into a base-relative path. | ||
| Skips over paths that contain variables.""" | ||
| """In MINGW node -p return a path with double quote""" | ||
| path = path.strip('"') |
There was a problem hiding this comment.
Given that this is a MINGW-only issue, would there be a way to rewrite as:
if on_mingw:
path = path.strip('"')There was a problem hiding this comment.
Kreijstal‘s fork be used for msys2 user，any plan merge to officail repo need to check MINGW platform.
There was a problem hiding this comment.
I mean yes but this branch is also a PR itself
nodejs#3166
so I would like to be friendly with node-gyp upstream eventually they should merge it of course...
3 participants
Checklist
npm install && npm run lint && npm testpassesDescription of change
related issue: nodejs#3120
Summary by Sourcery
Bug Fixes: