Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript location customization #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlchavez
Copy link

Following the pattern of other libraries from this author added support for settings the customization of the location of the javascript file.

This will allow to configure it on the Program.cs file:

services.AddURLService(c => { c.BasePath = "/_content/"; });

Following the pattern of other libraries from this author added support for settings the customization of the location of the javascript file.

This will allow to configure it on the Program.cs file:

services.AddURLService(c => { c.BasePath = "/_content/"; });
@KristofferStrube
Copy link
Owner

KristofferStrube commented Jun 24, 2024

Hey @jlchavez do you have a need for changing the location of the resource?

It is correct that I have employed this pattern in my Blazor.FileSystemAccess library, but I would rather use some time to discuss how we best support all the different use cases people might have in the simplest way possible before going forward with this PR.

Could I get you to create an issue on this repository where you describe your use case? Then, we can discuss different solutions and weigh their pros and cons against each other before making a PR.

I saw your related PR (KristofferStrube/Blazor.Streams#16), and I think the same applies to that one. However, let's discuss the best solution in this repository before continuing with that repository.

@jlchavez
Copy link
Author

Thanks for your response, I've created the Issue, and shared all my ideas about it, even though I've made a wrapper for locating and creating files in subfolders, and may be will try to contribute on the javascript side so that it can be optimized to one call from WASM to Javascript, reducing overhead and all the interop needed. :) Thanks for your work on this libraries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants