explicit default template context through get method #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 94.12% 94.12%
=======================================
Files 54 54
Lines 3593 3594 +1
Branches 460 460
=======================================
+ Hits 3382 3383 +1
Misses 134 134
Partials 77 77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Rajat-Ahuja1997
added a commit
to Rajat-Ahuja1997/cashews
that referenced
this pull request
Nov 11, 2025
This fixes a regression introduced in version 7.4.2 (commit a47f8ce) where ControlMixin's __disable ContextVar was changed from having a default value to using an explicit .set() call. This broke cross-context usage patterns like FastAPI's lifespan, where cache.setup() is called in one async context and cache operations happen in different contexts (HTTP requests). The issue is identical to Krukov#382, which was fixed for key_context.py in PR Krukov#383 (commit e22d2a7), but the same fix was not applied to ControlMixin. Changes: - Restore default=set() parameter to ControlMixin.__disable ContextVar - Remove redundant self.__disable.set(set()) call - Add test_control_mixin_cross_context to verify cross-context behavior This ensures that .get() returns a default value in all async contexts, not just the one where .set() was called, preventing LookupError.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fir for #382