Fix scripts not getting created for SafeRedis #387
Merged
+4
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds the
NoScriptErrorcheck/raise inSafeRedis, analogous to the change inRedisthat was made in #355.Why
Our Redis restarted for the first time (and thus cleared saved scripts) since we upgraded to include the changes in #355, and we started getting the following error printed in logs and caches never getting unlocked, spinning forever waiting for the unlock.
It seems that the new flow after #355 is to let the script get created by the redis lib upon getting the
NoScriptErroras we no longer explicitly callscript_load. But when usingSafeRedisrather than Redis, the error was getting swallowed and it was just returningNonefromclient.evalsharather than throwing, so it never triggers the except block to create the script. After these changes it does.