Skip to content

Conversation

PWagner1
Copy link
Contributor

@PWagner1 PWagner1 commented Aug 2, 2025

@PWagner1 PWagner1 self-assigned this Aug 2, 2025
@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. area:toolkit All issues related to the toolkit components. labels Aug 2, 2025
@PWagner1 PWagner1 added this to the Version 100 milestone Aug 2, 2025
Copy link
Contributor

@giduac giduac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If RTL is on and RTL LAyout is off the title bar and all it's buttons stay LTR.
image
  1. Also in this test:
    When RTL is on RTL Layout is off and FormTitleAlign is center:
    The system menu controlbox is also centered in the middle of the titlebar.

@giduac
Copy link
Contributor

giduac commented Aug 3, 2025

@PWagner1

Here are the four states as per Form.

B1697-CBB-Enabled-State_OGqsEeFWaW.mp4

@giduac
Copy link
Contributor

giduac commented Aug 3, 2025

And some more observations:
The same action has different results on ControlsTest and Rtl Test forms.
Also ( that worked before) when RTL is on and RTL layout is true controls are not mirrored anymore.

devenv_pfkXoJuRtP.mp4

@PWagner1
Copy link
Contributor Author

PWagner1 commented Aug 3, 2025

  1. If RTL is on and RTL LAyout is off the title bar and all it's buttons stay LTR.
image 2. Also in this test: When RTL is on RTL Layout is off and FormTitleAlign is center: The system menu controlbox is also centered in the middle of the titlebar.

@giduac

Fixed, I'm not concerned about other controls at the moment, they'll come later

image

@PWagner1
Copy link
Contributor Author

PWagner1 commented Aug 3, 2025

@giduac

Please can you re-test following todays modifications?

@giduac
Copy link
Contributor

giduac commented Aug 4, 2025

@giduac

Please can you re-test following todays modifications?

Later on or tomorrow...

@giduac giduac self-requested a review August 4, 2025 07:37
@PWagner1
Copy link
Contributor Author

PWagner1 commented Aug 4, 2025

@giduac

I think that I've figured out the problem and it's ridiculously stupid!

@giduac
Copy link
Contributor

giduac commented Aug 4, 2025

@PWagner1

Still work todo...

When FormTitleAlign is set to inherit the error below happens:
image

When RTl is on and RTL Layour ia on the controls are not mirrored.

image

@PWagner1
Copy link
Contributor Author

@giduac

I've now got the alignment to work, KPanel is now working...

@PWagner1 PWagner1 marked this pull request as ready for review August 16, 2025 10:59
@PWagner1
Copy link
Contributor Author

Ready for review

image

@giduac
Copy link
Contributor

giduac commented Aug 16, 2025

Hi @PWagner1,

RTL ON and RTL Layout off: the title bar should not change, but it does.

@PWagner1
Copy link
Contributor Author

RTL ON and RTL Layout off: the title bar should not change, but it does.

@giduac

Should now be resolved

@giduac
Copy link
Contributor

giduac commented Aug 16, 2025

......

TestForm_mimKJuAjiv.mp4

@PWagner1
Copy link
Contributor Author

......

TestForm_mimKJuAjiv.mp4

@giduac

I'm not worried about all of the controls at the moment, they'll be a separate task.

Will verify every possible case soon...

@PWagner1 PWagner1 marked this pull request as draft August 27, 2025 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants