Skip to content

Add image links to original image#69

Merged
openshift-merge-bot[bot] merged 3 commits intomainfrom
add-image-links
Nov 11, 2024
Merged

Add image links to original image#69
openshift-merge-bot[bot] merged 3 commits intomainfrom
add-image-links

Conversation

@david-martin
Copy link
Copy Markdown
Member

@david-martin david-martin commented Nov 8, 2024

The images in the blog post #67 are difficult to read the legend on.
This change makes the images links to the original (larger in this case) image size.

I've also renamed the file for that blog post to match the directory name (and included info in the README about this) so that the path doesn't include extra nesting.

@openshift-ci openshift-ci Bot requested review from alexsnaps and roivaz November 8, 2024 17:14
@openshift-ci openshift-ci Bot added the approved label Nov 8, 2024
@david-martin david-martin changed the base branch from BLOG/understanding_Cyclomatic_Complexity to main November 8, 2024 17:15
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Nov 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: david-martin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 8, 2024

Deploy Preview for relaxed-faloodeh-7fa6f1 ready!

Name Link
🔨 Latest commit deb39c4
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-faloodeh-7fa6f1/deploys/673215cff520a200082f2611
😎 Deploy Preview https://deploy-preview-69--relaxed-faloodeh-7fa6f1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@david-martin david-martin force-pushed the add-image-links branch 2 times, most recently from c610bce to 871b49e Compare November 11, 2024 10:41
@jasonmadigan
Copy link
Copy Markdown
Member

jasonmadigan commented Nov 11, 2024

@david-martin looking at the preview, we seem to have two links to that post now:

https://deploy-preview-69--relaxed-faloodeh-7fa6f1.netlify.app/blog/
Screenshot 2024-11-11 at 12 48 22

Old doc still there? Looks like it's seen as a new file rather than rename

Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: David Martin <davmarti@redhat.com>
Signed-off-by: David Martin <davmarti@redhat.com>
@david-martin
Copy link
Copy Markdown
Member Author

looking at the preview, we seem to have two links to that post now:

@jasonmadigan Fixed. The file rename actually added a 2nd file.
I've stepped through the rename in 2 commits and seems to be working now.

@jasonmadigan
Copy link
Copy Markdown
Member

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants