feat: add copy-to-clipboard button for webhook URL in Settings (#472) - #668
feat: add copy-to-clipboard button for webhook URL in Settings (#472)#668GeethaBurigalla wants to merge 1 commit into
Conversation
📝 WalkthroughWalkthroughAdds a disabled Webhook URL field and copy button to the Organization settings panel. JavaScript populates the URL from ChangesWebhook URL settings
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
frontend/settings.html (1)
135-137: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winUse a labeled, read-only input.
disabledprevents keyboard focus and selection, while the field is intended to display a read-only URL. Associate the label and usereadonlyinstead.Proposed fix
-<label class="form-label small text-muted fw-semibold">Webhook URL</label> +<label for="webhook-url" class="form-label small text-muted fw-semibold">Webhook URL</label> ... -<input type="text" class="form-control" id="webhook-url" disabled> +<input type="text" class="form-control" id="webhook-url" readonly>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@frontend/settings.html` around lines 135 - 137, Update the Webhook URL field in the settings markup to use readonly instead of disabled, and associate the label with the input via matching for/id attributes. Preserve the existing styling and webhook-url identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@frontend/settings.html`:
- Around line 135-137: Update the Webhook URL field in the settings markup to
use readonly instead of disabled, and associate the label with the input via
matching for/id attributes. Preserve the existing styling and webhook-url
identifier.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: faf03ecb-530f-48b3-8124-73349198e210
📒 Files selected for processing (1)
frontend/settings.html
Description
Adds a read-only Webhook URL field to the Organization card in Settings, with a copy-to-clipboard button — reuses the existing copyToClipboard helper and matches the pattern already used for the Organization ID field.
The URL points to the existing email webhook endpoint (
/api/v1/webhooks/email/) that SendGrid/Mailgun events already hit for open/click/bounce tracking — this just makes it visible and easy to copy for users setting up their provider.Resolves #472.
Summary by CodeRabbit