Skip to content

feat: add copy-to-clipboard button for webhook URL in Settings (#472) - #668

Open
GeethaBurigalla wants to merge 1 commit into
Kuldeeep18:mainfrom
GeethaBurigalla:feat/webhook-url-copy-472
Open

feat: add copy-to-clipboard button for webhook URL in Settings (#472)#668
GeethaBurigalla wants to merge 1 commit into
Kuldeeep18:mainfrom
GeethaBurigalla:feat/webhook-url-copy-472

Conversation

@GeethaBurigalla

@GeethaBurigalla GeethaBurigalla commented Jul 12, 2026

Copy link
Copy Markdown

Description

Adds a read-only Webhook URL field to the Organization card in Settings, with a copy-to-clipboard button — reuses the existing copyToClipboard helper and matches the pattern already used for the Organization ID field.

The URL points to the existing email webhook endpoint (/api/v1/webhooks/email/) that SendGrid/Mailgun events already hit for open/click/bounce tracking — this just makes it visible and easy to copy for users setting up their provider.

Resolves #472.

Summary by CodeRabbit

  • New Features
    • Added a Webhook URL field to Organization settings.
    • Added a copy-to-clipboard button for the webhook URL.
    • Included guidance about email open, click, and bounce events.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds a disabled Webhook URL field and copy button to the Organization settings panel. JavaScript populates the URL from oauthHost and copies it through the existing clipboard helper.

Changes

Webhook URL settings

Layer / File(s) Summary
Display and copy webhook URL
frontend/settings.html
Adds the read-only webhook URL input, explanatory helper text, copy button, URL population, and clipboard click handler.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The PR adds the webhook URL field and copy button, but confirmation feedback and the exact clipboard helper behavior are not verifiable from the summary. Confirm the button uses clipboard copy logic and shows feedback such as a checkmark or Copied! message as requested in #472.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: adding a copy-to-clipboard webhook URL button in Settings.
Out of Scope Changes check ✅ Passed The changes stay focused on the Settings webhook URL copy feature and related wiring.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
frontend/settings.html (1)

135-137: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Use a labeled, read-only input.

disabled prevents keyboard focus and selection, while the field is intended to display a read-only URL. Associate the label and use readonly instead.

Proposed fix
-<label class="form-label small text-muted fw-semibold">Webhook URL</label>
+<label for="webhook-url" class="form-label small text-muted fw-semibold">Webhook URL</label>
...
-<input type="text" class="form-control" id="webhook-url" disabled>
+<input type="text" class="form-control" id="webhook-url" readonly>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/settings.html` around lines 135 - 137, Update the Webhook URL field
in the settings markup to use readonly instead of disabled, and associate the
label with the input via matching for/id attributes. Preserve the existing
styling and webhook-url identifier.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@frontend/settings.html`:
- Around line 135-137: Update the Webhook URL field in the settings markup to
use readonly instead of disabled, and associate the label with the input via
matching for/id attributes. Preserve the existing styling and webhook-url
identifier.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: faf03ecb-530f-48b3-8124-73349198e210

📥 Commits

Reviewing files that changed from the base of the PR and between 4a33158 and f638f54.

📒 Files selected for processing (1)
  • frontend/settings.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LO-105 [Easy]: Copy-to-Clipboard Button for Webhook URLs in Settings

1 participant