Skip to content

fix: trim whitespace in login and registration serializers (#474) #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GeethaBurigalla wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: trim whitespace in login and registration serializers (#474) #671

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backend/users/jwt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,11 @@

class CustomTokenObtainSerializer(TokenObtainPairSerializer):
username_field = 'email'

def validate(self, attrs):
# Strip stray whitespace from copy-pasted emails (Issue #474).
# Password is intentionally left untouched.
if isinstance(attrs.get(self.username_field), str):
attrs[self.username_field] = attrs[self.username_field].strip()
return super().validate(attrs)

7 changes: 7 additions & 0 deletions backend/users/serializers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,17 @@ class RegisterSerializer(serializers.Serializer):
last_name = serializers.CharField(required=False)

def validate_email(self, value):
value = value.strip()
if User.objects.filter(email__iexact=value).exists():
raise serializers.ValidationError('A user with this email already exists.')
return value

def validate_first_name(self, value):
return value.strip() if value else value

def validate_last_name(self, value):
return value.strip() if value else value

def create(self, validated_data):
org = Organization.objects.create(name=validated_data['organization_name'])
user = User.objects.create_user(
Expand Down