Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified .gitignore
Binary file not shown.
30 changes: 25 additions & 5 deletions backend/campaigns/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

from bs4 import BeautifulSoup
from celery import shared_task
from celery.exceptions import MaxRetriesExceededError, Retry
from django.conf import settings as django_settings
from django.core.signing import Signer
from django.db.models import Q
Expand Down Expand Up @@ -541,8 +542,13 @@ def rewrite_email_links(html_body, campaign_lead_id, step_id):
# -----------------------------------


@shared_task
def send_email_step(campaign_lead_id, step_id):
@shared_task(
bind=True,
acks_late=True,
max_retries=3,
default_retry_delay=900,
)
def send_email_step(self, campaign_lead_id, step_id):
"""
Dispatch an email through the selected connected account or fall back to mock logging.
"""
Expand Down Expand Up @@ -613,16 +619,30 @@ def send_email_step(campaign_lead_id, step_id):
clead.last_sent_message_id = message_id
clead.save(update_fields=['last_sent_message_id'])
except Exception as send_err:
logger.error(f"Email send failed for {clead.lead.email}: {send_err}")
# Restore next_execution_time so the lead can be retried later.
logger.error(
f"Email send failed for {clead.lead.email}: {send_err}"
)

clead.next_execution_time = timezone.now() + timedelta(minutes=15)
clead.save(update_fields=['next_execution_time'])
clead.save(update_fields=["next_execution_time"])

try:
self.retry(exc=send_err)

except MaxRetriesExceededError:
logger.error(
f"Max retries exceeded for {clead.lead.email}"
)

return
else:
logger.info(f"Mock SENDING EMAIL to {clead.lead.email} | Subject: {subject}")

_advance_to_next_step(clead, step)

except Retry:
raise

except Exception as e:
logger.error(f"Failed to send email step: {e}")

Expand Down
2 changes: 1 addition & 1 deletion backend/campaigns/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ def test_send_email_step_does_not_advance_when_gmail_send_fails(self):
)

with patch('campaigns.tasks.send_gmail', side_effect=Exception('gmail disabled')):
send_email_step(campaign_lead.id, email_step.id)
send_email_step.run(campaign_lead.id, email_step.id)

campaign_lead.refresh_from_db()
self.assertEqual(campaign_lead.current_step_id, email_step.id)
Expand Down