-
Notifications
You must be signed in to change notification settings - Fork 153
feat(campaigns): implement Sandbox Mode for safe campaign testing (#397) #690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SurinderTech
wants to merge
2
commits into
Kuldeeep18:main
Choose a base branch
from
SurinderTech:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| from django.conf import settings | ||
| from django.db import migrations, models | ||
| import django.db.models.deletion | ||
|
|
||
|
|
||
| class Migration(migrations.Migration): | ||
|
|
||
| dependencies = [ | ||
| ('campaigns', '0010_custom_mailbox_security_updates'), | ||
| migrations.swappable_dependency(settings.AUTH_USER_MODEL), | ||
| ] | ||
|
|
||
| operations = [ | ||
| migrations.AddField( | ||
| model_name='campaign', | ||
| name='created_by', | ||
| field=models.ForeignKey( | ||
| blank=True, | ||
| help_text='The user who created this campaign. Used as the Sandbox Mode test-email recipient.', | ||
| null=True, | ||
| on_delete=django.db.models.deletion.SET_NULL, | ||
| related_name='created_campaigns', | ||
| to=settings.AUTH_USER_MODEL, | ||
| ), | ||
| ), | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🩺 Stability & Availability | 🟠 Major | 🏗️ Heavy lift
Race condition on global Gemini configuration.
genai.configure(api_key=final_api_key)mutates the global configuration for the Google Generative AI library. If your email workers use threads or coroutines (e.g.,ThreadPoolExecutor, gevent) to process campaigns concurrently, tasks will overwrite each other's API keys. This can lead to authentication failures or cross-tenant billing issues where one tenant's request executes using another tenant's key.Even if workers run sequentially (e.g., Celery prefork), re-configuring the global client on every email send is an anti-pattern that may cause unexpected connection reuse or resource leaks.
If you are using the older
google-generativeaiSDK, consider migrating to the officialgoogle-genaiSDK where you can instantiate a localized, thread-safe client per request viaclient = genai.Client(api_key=final_api_key). Otherwise, ensure your worker concurrency model uses strictly isolated processes rather than threads to prevent key collisions.🤖 Prompt for AI Agents