Fix overlooked jquery link + remove bootstrap4#24
Merged
Kunsi merged 2 commits intoKunsi:mainfrom Oct 12, 2024
Merged
Conversation
Kunsi
reviewed
Oct 10, 2024
| <title>{{ request.event.name }} room info</title> | ||
| {% compress js %} | ||
| <script src="{% static "vendored/jquery-3.1.1.js" %}"></script> | ||
| <script src="{% static "js/jquery.js" %}"></script> |
Owner
There was a problem hiding this comment.
I have pushed some commits that remove the need for jQuery altogether. Will merge this after the pretalx commit is merged, then remove those lines.
Collaborator
Author
|
pretalx/pretalx#1846 is merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretalx is about to rip out django-bootstrap4 (which was the reason for the whole jQuery fuss), and forms can now be rendered simply with
{{ form }}or{{ form.field.as_field_group }}once pretalx/pretalx#1846 is merged (hopefully today).