Skip to content

SPSC: Relaxed load if value is only written in same thread #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mgeier wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SPSC: Relaxed load if value is only written in same thread #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/bounded/spsc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ impl<T> Queue<T> {
}

// Return an error if the queue is full.
let write = self.write.load(Acquire);
let write = self.write.load(Relaxed);
if write.wrapping_sub(self.read_copy.get()) == self.buffer.size() {
self.read_copy.set(self.read.load(Acquire));
if write.wrapping_sub(self.read_copy.get()) == self.buffer.size() {
Expand All @@ -172,7 +172,7 @@ impl<T> Queue<T> {

fn consume(&self) -> Result<T, ConsumeError> {
// Return an error if the queue is empty.
let read = self.read.load(Acquire);
let read = self.read.load(Relaxed);
if read == self.write_copy.get() {
self.write_copy.set(self.write.load(Acquire));
if read == self.write_copy.get() {
Expand Down