Generic Extends trait for pointer chains#397
Open
ecoskey wants to merge 3 commits intoKyleMayes:masterfrom
Open
Generic Extends trait for pointer chains#397ecoskey wants to merge 3 commits intoKyleMayes:masterfrom
Extends trait for pointer chains#397ecoskey wants to merge 3 commits intoKyleMayes:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a bit of an opinionated change, but I replaced the various
Extends${struct}traits with a singleExtends<T>trait. It's maybe a bit more idiomatic, and would help with some utilities I'm writing for owned pointer chains. It's not super critical for me though, so feel free to close if it's not something you want 🙂