Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Replace hacky workarounds for run configs #173

Merged
merged 1 commit into from
Dec 5, 2024
Merged

build: Replace hacky workarounds for run configs #173

merged 1 commit into from
Dec 5, 2024

Conversation

jpenilla
Copy link
Member

@jpenilla jpenilla commented Dec 1, 2024

depends on #172

@zml2008 zml2008 added this to the 6.1.1 milestone Dec 1, 2024
zml2008
zml2008 requested changes Dec 4, 2024
View reviewed changes
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, would you resolve the conflicts here when you have a sec?

@jpenilla jpenilla marked this pull request as ready for review December 5, 2024 00:29
zml2008
zml2008 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@zml2008 zml2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tyty

@zml2008 zml2008 self-assigned this Dec 5, 2024
@zml2008 zml2008 merged commit 2790357 into mc/1.21 Dec 5, 2024
2 checks passed
@zml2008 zml2008 deleted the build-improvements branch December 5, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zml2008 zml2008 zml2008 approved these changes

Assignees

@zml2008 zml2008

Labels
None yet
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jpenilla @zml2008