Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Rename LinearComponents.linear to Component.compose #258

Open
wants to merge 1 commit into
base: main/4
Choose a base branch
from

Conversation

zml2008
Copy link
Member

@zml2008 zml2008 commented Jan 11, 2021

Closes #225

Copy link
Member

@lucko lucko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I agree with this change :)

However, I'm not a huge fan of the name compose. (I raised this in our dev chat but figured I should say here too!)

In my mind, compose is more akin to Function#compose / functional composition than joining/concatenating text elements together.

I would prefer join - but it was noted that this would conflict with the existing method. I personally don't think that's a huge issue (the methods have a similar behaviour) but I also suggested joinWithInlineStyle or just joinInline in response.

Interested to hear if anyone else agrees (happy ofc to settle for the current proposal if it's just me 😆 ) or if there's an even better name I may be overlooking. :)

@zml2008 zml2008 added status: blocked status: needs discussion An issue or PR that requires design decisions or further consensus building before it can be merged and removed status: blocked labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs discussion An issue or PR that requires design decisions or further consensus building before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve documentation and discoverabilty of LinearComponents.linear()
4 participants