Add Context#preProcess to resolve all preProcess tags #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will add a new method to context to allow TagResolvers to replace PreProcess tags with the String value. It has a recursion limit to deny stack overflows from recursions
|
I'm sort of reluctant to expand the API around pre-process tags -- it's one more thing to deprecate if we end up finding a better alternative to those tags. The alternative currently would be deserializing a string as a |
zml2008
added
the
status: needs discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to Context. With this method you can resolve preProcess tags in your own TagResolver.
This should be handy for TagResolvers which do not directly insert components and want to have some sort of recursive resolvers.
I added a recursion limit to throw an exception once the TagResolvers tried 10 times to preProcess those tags.