Let tachograph.lua work with lua5.3 while being backwards compatible. #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lua 5.3 changes the way behaves with floats and integers. To maintain the same output as with Lua 5.2 convert #atr to integer. This way cold ATR appears as for example 23 instead 23.0. Signed-off-by: David Santamaría Rogado <[email protected]>
This changes the bare-minimum to let tachograph.lua work over Lua 5.3. Just the ISO-8859- part converted to integer to avoid conversion be nil and the hours calculation floored. Signed-off-by: David Santamaría Rogado <[email protected]>
Just convert to integers some output values to avoid .0 appearing in the output. Signed-off-by: David Santamaría Rogado <[email protected]>
howl
force-pushed
the
tachograph-lua5.3
branch
from
aa0048c to
1450a9b
Compare
|
Ok, my first amend to a non last commit. I have changed the commit message of the bare minimum changes to also reflect that hours calculation have been floored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just makes the necesarry changes to apdu.lua and tachograph.lua to work with Lua 5.3 and also maintain the same output.
Signed-off-by: David Santamaría Rogado [email protected]