Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test versions. #135

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Update test versions. #135

merged 5 commits into from
Jul 9, 2024

Conversation

ebezzam
Copy link
Member

@ebezzam ebezzam commented Jul 9, 2024

Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

@ebezzam ebezzam merged commit 8ed5136 into main Jul 9, 2024
9 checks passed
@ebezzam ebezzam deleted the fix_tests branch July 9, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant