Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better ploting for benchmark result #70

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Conversation

YohannPerron
Copy link
Contributor

@YohannPerron YohannPerron commented Jul 26, 2023

Small change to the plotting at the end of benchmark_recon.py to make the plot more readable. As of now the legend is only plotted on the reconstruction error graph. But I can but it everywhere if it is preferred.

Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

@ebezzam ebezzam merged commit 09e96c1 into LCAV:main Jul 31, 2023
@ebezzam ebezzam deleted the BetterPlot branch July 31, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants