Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move drunet utilities to recon module. #71

Merged
merged 1 commit into from
Jul 31, 2023
Merged

Move drunet utilities to recon module. #71

merged 1 commit into from
Jul 31, 2023

Conversation

ebezzam
Copy link
Member

@ebezzam ebezzam commented Jul 28, 2023

Thank you for submitting a pull request (PR)! Before hitting the submit button, we would be really glad if you check all the following points. Even if you can't check all the boxes below, do not hesitate to go ahead with the PR and ask for help there.

Please also refer to the doc on contributing for more details.

  • Have you run the tests by running pytest from the repository root? See the documentation for more details.
  • Do you follow the code formatting for this project? This can be done by setting up pre-commit hooks as described in the documentation.
  • Is there a unit test for the proposed code modification? If the PR addresses an issue, the test should make sure the issue is fixed.
  • Are there docstrings? Do they follow the numpydoc style?
  • Have you checked that the doc builds properly and that any new RST file has been added to the repo? How to do that is covered in the documentation.
  • Did you document the proposed change(s) in the CHANGELOG file? It should go under "Unreleased".

Happy PR 😃

@ebezzam ebezzam merged commit d772114 into main Jul 31, 2023
24 checks passed
@ebezzam ebezzam deleted the drunet branch July 31, 2023 07:57
return image


def get_drunet_function(model, device="cpu", mode="inference"):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mode = "train" would be a safer default. I expect this function to be mostly use during training, and even if it is mistakenly used during inference, it should only make things slightly slower (while the other ways would cause multiple bugs)

@YohannPerron
Copy link
Contributor

Other wise, everything seems ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants