Migrate to no longer use SEP and use astropy Photutils instead. #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchate6
requested changes
Oct 24, 2023
| # Note that threshold is number of sigma, not an absolute number because we provide the error | ||
| # array to SEP. | ||
| threshold = 10.0 | ||
| threshold = 2.5 |
There was a problem hiding this comment.
where did this threshold come from? Is it no longer a number of sigma but an absolute number?
There was a problem hiding this comment.
It should be a number of sigma. The original goal was to have sep go down to all pixels that are 2.5 sigma above background, but we got a bunch of overflows. On normal images this works now.
jchate6
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.