econd live decoding #308
Merged
econd live decoding #308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looking at templating over DaqRunConsumer derived classes, getting complicated quickly unfortunately
…252) * update justfile recipes * working from a file of ECOND pedestals * Apply clang-format --style=Google * fixup violinplot * rename len for clarity * rename contrib to econ id * limit econ id to 10bits so it doesn't overwrite version * start outline of live decoding looking at templating over DaqRunConsumer derived classes, getting complicated quickly unfortunately * added tasks/level_pedestals.cxx to algorithm/level_pedestals.cxx and replaced hardcoded SIMPLEROC with pftool::state.daq_format_mode, set by DAQ->SETTINGS->FORMAT * Apply clang-format --style=Google * Apply clang-format --style=Google * adding templated helper function to get pedestal runs, utilizing eventPacket template * Apply clang-format --style=Google * level_pedestals.cxx needed scope adjustment * Apply clang-format --style=Google * adding multi sample packet header in place of 'soft wrapped.h' for econd * softwrapped->multi in level_peds * Apply clang-format --style=Google * added another declaration of the_log_ in pedestal_runs function * adding calc of links, channels for ECOND multi sample event packet mode * Apply clang-format --style=Google * inital code to take simple econ snapshot * allow different econ channel numbers * adding to econ menu * fix include * adding second BX to check, to ensure sensible hex output * adding second BX to check, to ensure sensible hex output * very inconsistent. debugging. * needed to re order fast commands * Adding summary line to alignment * Adding reset_stream for formatting * Adding missing ECON register config * Adding missing ECON register config * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to toa_vref_scan * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to toa_vref_scan * Apply clang-format --style=Google * adding helper function that is templated * adding helper function that is templated * passing target to helper function by reference * Apply clang-format --style=Google * Adding templating to get_toa_efficiencies cxx and h files * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to trim_toa_scan. Also adding helper function as i did with the other tasks to facilitate template use (EventPacket) * Apply clang-format --style=Google * declaring new the_log_ inside helper, and passing final_Data by ref to helper * Apply clang-format --style=Google * changed DaqRunConsumer to DAQRunConsumer in daq.cxx. Changed multiSmaple cxx and header file to include a to_csv_header module. also changed SoftWrappedECOND to MultiSampleECOND in daq.cxx around line 300's * added to MultiSampleECONDEventPacket.h: to_csv_header, to_csv, and DAQLinkFrame 'daq_links'. \n Also added to MultiSampleECONDEventPacket.cxx: to_csv_header, and to_csv based on what was in SingleROCEventPacket.cxx * adding daq format dependent logic to the CHARGE_TIMEIN section * Apply clang-format --style=Google * Syntax in daq_run for templated class definition apparently incorrect. fixing. Also, adjusting daqrun header file to make EventPacket const in the write event argument of DecodeAndWriteToCSV definition * Same syntax issue in DecodeAndBuffer constructor * implement similar switch statement for daq format on 'writer' definition * Apply clang-format --style=Google * Index the channel correctly for multi event packet taking acount of the sample number, and the i_link (as in level peds.cxx) * Apply clang-format --style=Google * 'ch' -> 'channel' * Apply clang-format --style=Google * scope issue * Apply clang-format --style=Google * implementing helper function and removing case structure for chargetimescan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for chargetimescan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for gen_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for gen_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * add link and i_ch variables for different addressing of ep objects * Apply clang-format --style=Google * passing trigger to helper * Apply clang-format --style=Google * missing ; * Apply clang-format --style=Google * missing ; * implementing helper function for inv_vref_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * re declaring the channels array as an srd::array * Apply clang-format --style=Google * noinv_vref_scan updated for event packet type * Apply clang-format --style=Google * paramter_timescan updated for event packet type * Apply clang-format --style=Google * sampling_phase_scan updated for event packet type * Apply clang-format --style=Google * adding template to helper function definitions on those cxxs I just modified * Apply clang-format --style=Google * set_toa adjusted for dynamic event packet based behaviour * Apply clang-format --style=Google * replaceing cmakelists * toa_scan updated for event packets * Apply clang-format --style=Google * 276 econ snapshots (#280) * inital code to take simple econ snapshot * allow different econ channel numbers * adding to econ menu * fix include * adding second BX to check, to ensure sensible hex output * adding second BX to check, to ensure sensible hex output * very inconsistent. debugging. * needed to re order fast commands * Adding summary line to alignment * Adding reset_stream for formatting * Adding missing ECON register config * Adding missing ECON register config * Apply clang-format --style=Google * Adjust fastcontrol enables, econ align task (#278) * add as option to pftool main * cleanup zcu target, remove incorrect comments * able to start constructing a BW target, failing when trying to do standard setup * remove /4 since bittware_axilite is byte-based addressing * fixup olink names, fixup base addr for rocs relative to backplane * throw exception if failed to read one reg * leave in example of how to check fw vers * store what we know in comments * parse link for --bw arg * Apply clang-format --style=Google * daq and elinks initial drafts, not fully ready * Adjust the enables for FC * Implement alignment task * Apply clang-format --style=Google --------- Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> * reorg code a bit - move econ_snapshot alongside the econ menu where it is used - have tasks/align_phase_word pull from econ_snapshot - move pftool::readline calls outside of econ_snapshot function - remove commented-out loops * Apply clang-format --style=Google --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: Jeremiah Mans <[email protected]> * cleanup econ parameter applicatoin * More conda package dev (#281) * use differnet build dir for conda to avoid clash * unpin rogue * update conda notes * start EcalSMM Bittware target (#282) * get ecalsmm bw target compiling * update configs with re-cabling * add slac lab1 hcalbackplane econd config * Apply clang-format --style=Google --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * mark Boost include as SYSTEM to avoid annoying warnings * update notes on develping on slac daq server * Jeremy patches while dev (#284) * Fix addresses * Need to have on/off of L1A enable * Apply clang-format --style=Google --------- Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Bump actions/checkout from 5 to 6 (#285) Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ECON-ROC align on bittware (#286) * Working to align ROC and ECON on bittware * Configure the ROC to the right timing also for ALIGN * Apply clang-format --style=Google * update readout cfg state name for EcalSMM BW Target --------- Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * tidied up and corrected noinv_vref_scan.cxx * Apply clang-format --style=Google * ....semicolon * Apply clang-format --style=Google * inv_ref -> noinv_ref correction * remove channels from helper function call * remove channels altogether for noinv_vref_scan * fixing some parameter passing issues in parameter_timescan macro * Apply clang-format --style=Google * add event packet template to helper function * fixing some MORE parameter passing issues in parameter_timescan macro * Apply clang-format --style=Google * channel -> ch * fixing parameter mistakes in samplingphase .cxx * test set_toa.cxx * Apply clang-format --style=Google * toa macro parameter mistakes * Apply clang-format --style=Google * On call to .adc() needed packet type distinction for indexing channels vs samples for single vs multi sample packet type * Apply clang-format --style=Google * updating trim_inv_dacb_Scan for dynamic eventpacket type behaviour * Apply clang-format --style=Google * Adding output_filepath to function call * Adding output_filepath to function call * Actually implementing template for EP * Apply clang-format --style=Google * Adding logic for packet dependent channel/sample indexing on call to adc() function * Apply clang-format --style=Google * Scoping bracket issue * Apply clang-format --style=Google * Overhaul of vt50_scan for event packet dependent behaviour, implemented helper function, just like the other macros * Apply clang-format --style=Google * vt50_typo * Apply clang-format --style=Google * one remaining singleROCeventpacket that should have been a template reference * one remaining index of channel that needed correcting for Multi sample, in the call to tot() function * one remaining erroneous line * Apply clang-format --style=Google * Added explicit template instantiations to daq_run.cxx * Apply clang-format --style=Google * Replace event packet object instantiation in daq_run.h, in the DecodeAndWrite template definition, with a unique pointer, because then one can pass arguments which are necessary for multisample event packets * Adding explicit default constructor with default nlinks=0 to be ignored by singleROCtype, but will be passed the nlinks dynamically for the multi sample type * Defining explicit default constructor in daq_run.cxx which takes n_links * creating econ_links.h which takes the econ target object and counts active n_links. including this header in parameter_timescan, and adding n_links to the creation of DecodeAndWriteToCSV * Apply clang-format --style=Google * Dereferecing ptr 'ep' in DecodeAndWrite::consume method in daq_run.cxx due to its redefinition as a uniqueptr in the template def in the daqrun.h * Apply clang-format --style=Google * slight adjustment * slight adjustment * Apply clang-format --style=Google * slight adjustment * Apply clang-format --style=Google * adding n_links to DecodeAndWriteToCSV with default value of 0 * Apply clang-format --style=Google * ALSO adding n_links to DecodeAndWriteToCSV in cxx as well as header with default value of 0 * Apply clang-format --style=Google * removing default nlinks arg value from cxx file * Apply clang-format --style=Google * adding get_toa_Efficiencies() instantiation to the cxx file, like I had to for daq_run.cxx, because the templates are defined in the cxx file so the compiler needs to know how to use them by pre compiling. * Apply clang-format --style=Google * adding packet check to appropriate channel indexing in get_toa_Efficiencies.cxx, same as for other tasks * Apply clang-format --style=Google * slight adjust * Apply clang-format --style=Google * slight adjust including pftool in get_toa_eff.h * Apply clang-format --style=Google * adding n_links to all relevent cxx files for tasks. charge_timescan, gen_scan, inv_vref_scan, noinv_vref_scan, sampling_phase_scan,toa_scan, trim_inv_dacb_scan,vt50_scan. For the benefit of multisample packet types. applicable to DecodeAndWrite objects only * Apply clang-format --style=Google * removing a redeclaration * making link counting function inline * small adjustment * Apply clang-format --style=Google * Apply clang-format --style=Google * revert fix of python version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: Tom Eichlersmith <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
4 tasks
tvami
pushed a commit
that referenced
this pull request
Dec 9, 2025
* start outline of live decoding looking at templating over DaqRunConsumer derived classes, getting complicated quickly unfortunately * level_pedestals now has its daq format set by DAQ->SETTINGS->FORMAT (#252) * update justfile recipes * working from a file of ECOND pedestals * Apply clang-format --style=Google * fixup violinplot * rename len for clarity * rename contrib to econ id * limit econ id to 10bits so it doesn't overwrite version * start outline of live decoding looking at templating over DaqRunConsumer derived classes, getting complicated quickly unfortunately * added tasks/level_pedestals.cxx to algorithm/level_pedestals.cxx and replaced hardcoded SIMPLEROC with pftool::state.daq_format_mode, set by DAQ->SETTINGS->FORMAT * Apply clang-format --style=Google * Apply clang-format --style=Google * adding templated helper function to get pedestal runs, utilizing eventPacket template * Apply clang-format --style=Google * level_pedestals.cxx needed scope adjustment * Apply clang-format --style=Google * adding multi sample packet header in place of 'soft wrapped.h' for econd * softwrapped->multi in level_peds * Apply clang-format --style=Google * added another declaration of the_log_ in pedestal_runs function * adding calc of links, channels for ECOND multi sample event packet mode * Apply clang-format --style=Google * inital code to take simple econ snapshot * allow different econ channel numbers * adding to econ menu * fix include * adding second BX to check, to ensure sensible hex output * adding second BX to check, to ensure sensible hex output * very inconsistent. debugging. * needed to re order fast commands * Adding summary line to alignment * Adding reset_stream for formatting * Adding missing ECON register config * Adding missing ECON register config * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to toa_vref_scan * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to toa_vref_scan * Apply clang-format --style=Google * adding helper function that is templated * adding helper function that is templated * passing target to helper function by reference * Apply clang-format --style=Google * Adding templating to get_toa_efficiencies cxx and h files * Apply clang-format --style=Google * adding daqformat dependent call to DecodeAndBuffer to trim_toa_scan. Also adding helper function as i did with the other tasks to facilitate template use (EventPacket) * Apply clang-format --style=Google * declaring new the_log_ inside helper, and passing final_Data by ref to helper * Apply clang-format --style=Google * changed DaqRunConsumer to DAQRunConsumer in daq.cxx. Changed multiSmaple cxx and header file to include a to_csv_header module. also changed SoftWrappedECOND to MultiSampleECOND in daq.cxx around line 300's * added to MultiSampleECONDEventPacket.h: to_csv_header, to_csv, and DAQLinkFrame 'daq_links'. \n Also added to MultiSampleECONDEventPacket.cxx: to_csv_header, and to_csv based on what was in SingleROCEventPacket.cxx * adding daq format dependent logic to the CHARGE_TIMEIN section * Apply clang-format --style=Google * Syntax in daq_run for templated class definition apparently incorrect. fixing. Also, adjusting daqrun header file to make EventPacket const in the write event argument of DecodeAndWriteToCSV definition * Same syntax issue in DecodeAndBuffer constructor * implement similar switch statement for daq format on 'writer' definition * Apply clang-format --style=Google * Index the channel correctly for multi event packet taking acount of the sample number, and the i_link (as in level peds.cxx) * Apply clang-format --style=Google * 'ch' -> 'channel' * Apply clang-format --style=Google * scope issue * Apply clang-format --style=Google * implementing helper function and removing case structure for chargetimescan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for chargetimescan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for gen_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * implementing helper function and removing case structure for gen_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * add link and i_ch variables for different addressing of ep objects * Apply clang-format --style=Google * passing trigger to helper * Apply clang-format --style=Google * missing ; * Apply clang-format --style=Google * missing ; * implementing helper function for inv_vref_scan, to allow for daq format dependent behaviour * Apply clang-format --style=Google * re declaring the channels array as an srd::array * Apply clang-format --style=Google * noinv_vref_scan updated for event packet type * Apply clang-format --style=Google * paramter_timescan updated for event packet type * Apply clang-format --style=Google * sampling_phase_scan updated for event packet type * Apply clang-format --style=Google * adding template to helper function definitions on those cxxs I just modified * Apply clang-format --style=Google * set_toa adjusted for dynamic event packet based behaviour * Apply clang-format --style=Google * replaceing cmakelists * toa_scan updated for event packets * Apply clang-format --style=Google * 276 econ snapshots (#280) * inital code to take simple econ snapshot * allow different econ channel numbers * adding to econ menu * fix include * adding second BX to check, to ensure sensible hex output * adding second BX to check, to ensure sensible hex output * very inconsistent. debugging. * needed to re order fast commands * Adding summary line to alignment * Adding reset_stream for formatting * Adding missing ECON register config * Adding missing ECON register config * Apply clang-format --style=Google * Adjust fastcontrol enables, econ align task (#278) * add as option to pftool main * cleanup zcu target, remove incorrect comments * able to start constructing a BW target, failing when trying to do standard setup * remove /4 since bittware_axilite is byte-based addressing * fixup olink names, fixup base addr for rocs relative to backplane * throw exception if failed to read one reg * leave in example of how to check fw vers * store what we know in comments * parse link for --bw arg * Apply clang-format --style=Google * daq and elinks initial drafts, not fully ready * Adjust the enables for FC * Implement alignment task * Apply clang-format --style=Google --------- Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> * reorg code a bit - move econ_snapshot alongside the econ menu where it is used - have tasks/align_phase_word pull from econ_snapshot - move pftool::readline calls outside of econ_snapshot function - remove commented-out loops * Apply clang-format --style=Google --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: Jeremiah Mans <[email protected]> * cleanup econ parameter applicatoin * More conda package dev (#281) * use differnet build dir for conda to avoid clash * unpin rogue * update conda notes * start EcalSMM Bittware target (#282) * get ecalsmm bw target compiling * update configs with re-cabling * add slac lab1 hcalbackplane econd config * Apply clang-format --style=Google --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * mark Boost include as SYSTEM to avoid annoying warnings * update notes on develping on slac daq server * Jeremy patches while dev (#284) * Fix addresses * Need to have on/off of L1A enable * Apply clang-format --style=Google --------- Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Bump actions/checkout from 5 to 6 (#285) Bumps [actions/checkout](https://github.com/actions/checkout) from 5 to 6. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v5...v6) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * ECON-ROC align on bittware (#286) * Working to align ROC and ECON on bittware * Configure the ROC to the right timing also for ALIGN * Apply clang-format --style=Google * update readout cfg state name for EcalSMM BW Target --------- Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * tidied up and corrected noinv_vref_scan.cxx * Apply clang-format --style=Google * ....semicolon * Apply clang-format --style=Google * inv_ref -> noinv_ref correction * remove channels from helper function call * remove channels altogether for noinv_vref_scan * fixing some parameter passing issues in parameter_timescan macro * Apply clang-format --style=Google * add event packet template to helper function * fixing some MORE parameter passing issues in parameter_timescan macro * Apply clang-format --style=Google * channel -> ch * fixing parameter mistakes in samplingphase .cxx * test set_toa.cxx * Apply clang-format --style=Google * toa macro parameter mistakes * Apply clang-format --style=Google * On call to .adc() needed packet type distinction for indexing channels vs samples for single vs multi sample packet type * Apply clang-format --style=Google * updating trim_inv_dacb_Scan for dynamic eventpacket type behaviour * Apply clang-format --style=Google * Adding output_filepath to function call * Adding output_filepath to function call * Actually implementing template for EP * Apply clang-format --style=Google * Adding logic for packet dependent channel/sample indexing on call to adc() function * Apply clang-format --style=Google * Scoping bracket issue * Apply clang-format --style=Google * Overhaul of vt50_scan for event packet dependent behaviour, implemented helper function, just like the other macros * Apply clang-format --style=Google * vt50_typo * Apply clang-format --style=Google * one remaining singleROCeventpacket that should have been a template reference * one remaining index of channel that needed correcting for Multi sample, in the call to tot() function * one remaining erroneous line * Apply clang-format --style=Google * Added explicit template instantiations to daq_run.cxx * Apply clang-format --style=Google * Replace event packet object instantiation in daq_run.h, in the DecodeAndWrite template definition, with a unique pointer, because then one can pass arguments which are necessary for multisample event packets * Adding explicit default constructor with default nlinks=0 to be ignored by singleROCtype, but will be passed the nlinks dynamically for the multi sample type * Defining explicit default constructor in daq_run.cxx which takes n_links * creating econ_links.h which takes the econ target object and counts active n_links. including this header in parameter_timescan, and adding n_links to the creation of DecodeAndWriteToCSV * Apply clang-format --style=Google * Dereferecing ptr 'ep' in DecodeAndWrite::consume method in daq_run.cxx due to its redefinition as a uniqueptr in the template def in the daqrun.h * Apply clang-format --style=Google * slight adjustment * slight adjustment * Apply clang-format --style=Google * slight adjustment * Apply clang-format --style=Google * adding n_links to DecodeAndWriteToCSV with default value of 0 * Apply clang-format --style=Google * ALSO adding n_links to DecodeAndWriteToCSV in cxx as well as header with default value of 0 * Apply clang-format --style=Google * removing default nlinks arg value from cxx file * Apply clang-format --style=Google * adding get_toa_Efficiencies() instantiation to the cxx file, like I had to for daq_run.cxx, because the templates are defined in the cxx file so the compiler needs to know how to use them by pre compiling. * Apply clang-format --style=Google * adding packet check to appropriate channel indexing in get_toa_Efficiencies.cxx, same as for other tasks * Apply clang-format --style=Google * slight adjust * Apply clang-format --style=Google * slight adjust including pftool in get_toa_eff.h * Apply clang-format --style=Google * adding n_links to all relevent cxx files for tasks. charge_timescan, gen_scan, inv_vref_scan, noinv_vref_scan, sampling_phase_scan,toa_scan, trim_inv_dacb_scan,vt50_scan. For the benefit of multisample packet types. applicable to DecodeAndWrite objects only * Apply clang-format --style=Google * removing a redeclaration * making link counting function inline * small adjustment * Apply clang-format --style=Google * Apply clang-format --style=Google * revert fix of python version --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: tomeichlersmith <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: Tom Eichlersmith <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * delete extra file * update justfile to better handle non-denv situations * compiling and appears to be working now, onto testing * Apply clang-format --style=Google * have default output format depend on readout config * fixup comment since i was there --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: joshgreaves332 <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: Jeremiah Mans <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the ROC<->Channel<->Link mappings are even close to correct, but we can get something that live-decodes and then insert the remapping of the IDs after.
To Do
DAQ.PEDESTALwith live decoding works, I have not tested more advanced tasks because they rely on knowing how the link indices map onto different ROCs #294