Issue #810 Remove spaces in the MDR entities' and attributes' fields of name and uniqueName#868
Open
thelmick-unicon wants to merge 1 commit intoLIF-Initiative:mainfrom
Open
Issue #810 Remove spaces in the MDR entities' and attributes' fields of name and uniqueName#868thelmick-unicon wants to merge 1 commit intoLIF-Initiative:mainfrom
thelmick-unicon wants to merge 1 commit intoLIF-Initiative:mainfrom
Conversation
…butes' fields of name and uniqueName Fixes
cbeach47
requested changes
Mar 5, 2026
Contributor
cbeach47
left a comment
cbeach47
left a comment
There was a problem hiding this comment.
The openapi diff is pretty hard to see the differences - are the only changes in the openapi json file the adjusted Name / UniqueName fields after the database changes?
For the Flyway migration files - V1.2_... should be the just UPDATEs to create the deltas. The migration tool should recognize that V1.2_... hasn't been applied yet, and run the UPDATEs. I would rename V1.1_to_V1.2_delta.sql to V1.2__remove_reserved_characters.sql, and then remove the V1.2__metadata_repository_init.sql file.
Are you confident these entity / attribute IDs will be the same in Dev and Demo as they are in Local?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Description of Change
Include:
What problem does this solve?
Spaces, and other characters, in the MDR entities' and attributes' fields of name and uniqueName break the transforms.
What is the solution?
Removing the offending characters from the MDR data.
How should reviewers test this?
Review the data to see if any spaces, commas, colons, or tilde are in the dataset.
Related Issues
#801
Closes # [[add Github issue number]]
#810
Type of Change
to not work as expected)
Project Area(s) Affected