Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): add coverage over new parallel implementations #214

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented Oct 30, 2024

this adds coverage over additions of #201

it also fixes a problem highlighted by the new tests; the two_unsew methods were not correctly dealing with vertex attributes

@imrn99 imrn99 changed the title test: add coverage over new parallel implementations test(core): add coverage over new parallel implementations Oct 30, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 92.19331% with 42 lines in your changes missing coverage. Please review.

Project coverage is 81.73%. Comparing base (fdb2ed9) to head (df5b4eb).

Files with missing lines Patch % Lines
honeycomb-core/src/cmap/dim2/link_and_sew.rs 36.00% 32 Missing ⚠️
honeycomb-core/src/attributes/tests.rs 98.21% 7 Missing ⚠️
honeycomb-core/src/cmap/dim2/tests.rs 96.87% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
+ Coverage   75.29%   81.73%   +6.43%     
==========================================
  Files          41       41              
  Lines        6376     6866     +490     
==========================================
+ Hits         4801     5612     +811     
+ Misses       1575     1254     -321     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

is my 2-unsew false?
I might be a little challenged
@imrn99
Copy link
Collaborator Author

imrn99 commented Oct 30, 2024

the windows CI has decided it won't run 👍

@imrn99 imrn99 marked this pull request as ready for review October 31, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants