Skip to content

fix(preprocess): unify PR Newswire identities#124

Open
Sanjays2402 wants to merge 1 commit into
LLMQuant:masterfrom
Sanjays2402:fix/pr-newswire-public-identity
Open

fix(preprocess): unify PR Newswire identities#124
Sanjays2402 wants to merge 1 commit into
LLMQuant:masterfrom
Sanjays2402:fix/pr-newswire-public-identity

Conversation

@Sanjays2402

Copy link
Copy Markdown

Summary

PR Newswire observations now use the public build_news_identity helper, so callers can reproduce the identity stamped on collected documents. The focused regressions cover both discovery observations and collected documents.

Related Issue

Closes #110

Verification

  • Regression tests failed against the unchanged source and passed with this fix.
  • .venv/bin/python -m pytest -q --no-cov tests/preprocess/test_pr_newswire.py — 10 passed.
  • Ruff format/check and lint-imports passed.
  • basedpyright reports the same 12 unresolved optional-dependency imports with and without this diff in the minimal local environment; bash scripts/verify.sh therefore does not complete locally.
  • The live PR Newswire smoke test was not run in the network-denied local test environment.

Checklist

  • The title uses English Conventional Commit format: type(scope): summary.
  • The related issue or design discussion is linked when applicable.
  • bash scripts/verify.sh passes.
  • Every applicable live-network component smoke test passes, or this PR states why none applies.
  • Public behavior has focused tests, an example, and documentation where applicable.
  • The PR is complete, small, and contains no unrelated changes.

Use the public news identity builder when collecting PR Newswire documents so callers can reproduce stamped identities. Add offline regressions for discovery and collection.
@wanghaoxue0
wanghaoxue0 requested a review from keli-wen July 18, 2026 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: PR Newswire collector identity diverges from public build_news_identity

1 participant