fix(preprocess): unify PR Newswire identities#124
Open
Sanjays2402 wants to merge 1 commit into
Open
Conversation
Use the public news identity builder when collecting PR Newswire documents so callers can reproduce stamped identities. Add offline regressions for discovery and collection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR Newswire observations now use the public
build_news_identityhelper, so callers can reproduce the identity stamped on collected documents. The focused regressions cover both discovery observations and collected documents.Related Issue
Closes #110
Verification
.venv/bin/python -m pytest -q --no-cov tests/preprocess/test_pr_newswire.py— 10 passed.lint-importspassed.basedpyrightreports the same 12 unresolved optional-dependency imports with and without this diff in the minimal local environment;bash scripts/verify.shtherefore does not complete locally.Checklist
type(scope): summary.bash scripts/verify.shpasses.