Skip to content

Conversation

@white238
Copy link
Member

@white238 white238 commented Oct 14, 2025

  • Updates SUNDIALS past 7.0
  • Calls new MFEM Sundials Finalize to avoid calling MPI after our MPI_Finalize due to previous RAII static destructor logic

This cannot be merged until mfem/mfem#5073 goes into MFEM. Thanks @balos1 !

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.03%. Comparing base (db9409c) to head (c5366c9).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1482   +/-   ##
========================================
  Coverage    92.03%   92.03%           
========================================
  Files          199      200    +1     
  Lines        25212    25221    +9     
========================================
+ Hits         23203    23212    +9     
  Misses        2009     2009           
Flag Coverage Δ
unittests 92.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@white238
Copy link
Member Author

I'll clean this up after the other PR merges and i update MFEM with Cody's fix. Ignore for now.

@white238 white238 force-pushed the task/white238/update_sundials branch from 362f37b to 70ccd1b Compare October 22, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants