Skip to content

[Feature][AscendP2P]Add H2H host staging for Ascend P2P HCCL#259

Open
matthewygf wants to merge 1 commit into
LMCache:mainfrom
matthewygf:pr-h2h-host-staging
Open

[Feature][AscendP2P]Add H2H host staging for Ascend P2P HCCL#259
matthewygf wants to merge 1 commit into
LMCache:mainfrom
matthewygf:pr-h2h-host-staging

Conversation

@matthewygf

Copy link
Copy Markdown
Collaborator

Fixes #217 in P2P setup.

Problem

Currently when using HCCL channel, we have to register the entire CPU Buffer for zero copy RDMA Transfer.
However, for Ascend Hardware, this mean registering the CPU buffer onto the RoCE hardware, which could lead to Device OS OOM.

This PR

Instead of registering an entire CPU Buffer for zero copy RDMA transfer, this PR adds a staging area for H2H memobjs, then the remote one sided pull can directly pull from the staging area.

Furthermore, when a P2P pull fails, the system marks the corresponding blocks for local recomputation, preventing silent failures and improving reliability.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a host-staging mechanism for P2P transfers in the Ascend backend, utilizing a bounded pinned host arena instead of registering the entire CPU KV pool. It also implements lease tracking and expiration checks for one-sided reads, and adds error handling to mark failed P2P loads so that vLLM can fall back to local recomputation. There are no review comments, so I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@matthewygf matthewygf marked this pull request as ready for review June 29, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Failed to Register Mem to HCCL with Larger Models

1 participant