Skip to content

Conversation

darrell-k
Copy link
Contributor

A user reported login failure: it turned out to be a "Wide Character" error because their password included the symbol.

@michaelherger is this change fine with ancient Perl versions that might be in use?

Signed-off-by: darrell-k <[email protected]>
@michaelherger
Copy link
Member

A user reported login failure: it turned out to be a "Wide Character" error because their password included the symbol.

@michaelherger is this change fine with ancient Perl versions that might be in use?

I don't know, TBH. But I'd be positive. Except that I'm not sure whether we're good always encoding. This stuff has always confused me, as we sometimes need to encode, sometimes we don't, depending on the platform LMS is running on. That said this might be limited to data read from the file system rather than user input like a password.

I'd say go for it. It's simple enough to back out if needed. And I'm sure you tested with your own password?

@darrell-k
Copy link
Contributor Author

Tested with my own account (with a € symbol in the password) on:

Perl Version: 5.14.1 - MSWin32-x86-multi-thread
Perl Version: 5.32.1 - MSWin32-x64-multi-thread
Perl Version: 5.36.0 - aarch64-linux-gnu-thread-multi
Perl Version: 5.36.0 - aarch64-linux-gnu-thread-multi (Android/Termux)
Perl Version: 5.36.0 - x86_64-linux-gnu-thread-multi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants