Skip to content

RPM: Drop hard-coded Vendor tag #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mavit wants to merge 2 commits into
base: public/9.2
Choose a base branch
from
Open

RPM: Drop hard-coded Vendor tag #118

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0855f8
RPM: Drop hard-coded Vendor tag
mavit Jul 10, 2026
d671964
RPM: Drop redundant URL from Packager tag
mavit Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions redhat/lyrionmusicserver.spec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
%global shortname lyrionmusicserver

Name: %{src_basename}
Packager: Lyrion Community - please visit www.lyrion.org
Packager: Lyrion Community

@michaelherger michaelherger Jul 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you leave this in, but not the Vendor value? Just asking...

@mavit mavit Jul 14, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thinking was that if we build on Copr using this .spec file, the vendor would be Copr, but we would still be the packager.

That said, the difference between the purposes of the Vendor and Packager tags isn't clear, so perhaps we might as well drop the Packager tag entirely?

Version: %{_version}
Release: %{rpm_release}
Summary: Lyrion Music Server
Expand All @@ -88,7 +88,6 @@ Source5: README.systemd
Source6: README.rebranding
Source7: %{shortname}.preset
BuildRoot: %{_tmppath}/%{name}-%{version}-buildroot
Vendor: Lyrion Community

BuildRequires: systemd-rpm-macros
Requires(pre): /usr/bin/getent
Expand Down