Include album-link roles in unified artist list roles#1611
Open
darrell-k wants to merge 1 commit into
Open
Conversation
Signed-off-by: darrell-k <darrell@darrell.org.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is using the combined artist list, the albums query submitted when clicking a contributor name in the albums listing might fail to return results because the results are limited to the roles selected for the combined artist list.
This occurs if the name link in the albums list is present because of a role selected in the preference "artist links in album lists" but the same role is not selected in the unified list pref.
This fix adds adds the "album links" roles to the "unified list roles" in queries for a specific contributor with no role(s) specified.
See test results from @mikeysas here https://forums.lyrion.org/forum/user-forums/3rd-party-software/1828117-material-skin-shortcut-to-publisher-not-working?p=1828340#post1828340