Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON generated settings #1158

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

Conversation

CD-Z
Copy link
Collaborator

@CD-Z CD-Z commented Jul 19, 2024

Changes the General, Appearance, Reader and Repositories settings to be generated through json.
This way the same method can be used to create the quicksettings.

Additional Settings related changes:

  • added new tab "display" to the reader bottom sheet
  • added keyboard avoiding and width adjusting capabilities to the textAreaModal (CustomCss/Js)
  • adjustable size for the readersettings webview preview

@CD-Z CD-Z force-pushed the feature/dynamic_settings branch from efa1bce to a6b2d05 Compare September 20, 2024 08:15
@CD-Z
Copy link
Collaborator Author

CD-Z commented Oct 26, 2024

@rajarsheechatterjee @nyagami

@CD-Z
Copy link
Collaborator Author

CD-Z commented Oct 29, 2024

Aesthetic flaws.

1. when u custom the background with css this appears:
   ![Screenshot](https://private-user-images.githubusercontent.com/75091899/381145559-b3d4d6ef-d198-459f-9d17-a7418d409783.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzAyMDk4OTksIm5iZiI6MTczMDIwOTU5OSwicGF0aCI6Ii83NTA5MTg5OS8zODExNDU1NTktYjNkNGQ2ZWYtZDE5OC00NTlmLTlkMTctYTc0MThkNDA5NzgzLmpwZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDEwMjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQxMDI5VDEzNDYzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPThhNzJlNDEwMzgxYTJhMmFhM2EyYzhmMjgxMjE2ZGI5YTVmZDI3NjhhNTk2ODc2ZjQ1OWRjNGU1NDIxZWNlMjAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.x7aUrS-nFfVSTacy6BnhrlYrzeo_hhyUxkZqrE8hjqg)

2. When u move the preview size the white bar separates for some time

YouCut_20241029_143557107.mp4

I suggest to just remove the white part. Facultative, move the button externally like here: image

Can't reproduce.
Is it perhaps because of your css

@Palloxin
Copy link
Contributor

Bug
The glitch effect is still there:

YouCut_20241030_100946155.mp4

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Suggestion.
I saw the changed button in Repositories section.

There is still Categories section:

For how I see it, style Categories section too or revert the new button styling on repositories section.
This is just a suggestion.

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Aesthetic problem
your pr:

current beta:

There is decent spacing between the text and switch button in current beta.

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Aesthetic.
Switch buttons in settings of reading mode are bigger in your pr:

current beta:

Make them as in beta.

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Aesthetic + technical

Cant scroll them horizontally anymore:

YouCut_20241030_111115256.mp4

Same problem on app settings =>Reader

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Improvement
Make basic size(keyboard closed) of CSS/JS editor the same as current beta.

your pr:

current beta:

@Palloxin
Copy link
Contributor

Bug (or flaw idk)
Switching tabs(of reading mode settings) have a delay in your pr, which is annoying.

YouCut_20241030_095221205.mp4

@Palloxin
Copy link
Contributor

Bug
JS/CSS editor doesnt save if the box is emptied.

Steps to reproduce:

  1. go to customjs
  2. write something and save
  3. reopen js editor again
  4. delete everything to emptyness, then save

Result: will not save the second time (step 4)

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Incorrection

  1. clean install, import three epubs, 3 in a row showed in the library, but "4 in a row" text showed in the settings (image above)
  2. switched to "3 in a row" in the settings, on the library still 3 in a row showed
  3. switched to "4 in a row" in the settings again; on the library 4 in a row are showed.

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Bug
Description of options missing in General section of settings.

your pr

current beta:

@Palloxin
Copy link
Contributor

Palloxin commented Oct 30, 2024

Aesthetic suggestion
Revert these changes to current beta, it's better there:

your pr:

current beta:

@Palloxin

This comment was marked as resolved.

@Palloxin
Copy link
Contributor

Bug
Feature buttons presumebly swapped

YouCut_20241030_125813592.mp4

Unread badges shouldn't show the number on categories, bacuse that's the job of Show number of items.
Show number of items shouldn't trigger the unread badge either. So they have been swapped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants