-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve "Remove extra paragraph spacing" feature #1203
Open
Palloxin
wants to merge
47
commits into
LNReader:master
Choose a base branch
from
Palloxin:patch-3
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nyagami
reviewed
Aug 12, 2024
Removed until a concrete source example has them.
NovelUpdates - The Extra of The Bad Ending Game, chapter 159
This comment was marked as outdated.
This comment was marked as outdated.
doest match ``ahahah<br><br><br><br><br>ahahahaha``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repost of #1164 due to conflicts (related code moved to another file)
Currently, it just removes all
<br>
.With this change you could:
-remove excessive
<br>
-remove some zero-width spaces and
(I found a novel that put them in a p to simulate an extra empty paragraph).-remove a br after the end of a p. It's just extra space.
-remove a br present right before the end of a p.
EDIT: the feature code has regex chaining now.