Skip to content

Polish hotkey release behavior - #5

Merged
LTCyogi merged 1 commit into
LTCyogi:masterfrom
joshwegener:pr/04-hotkey-input-polish
Apr 4, 2026
Merged

Polish hotkey release behavior#5
LTCyogi merged 1 commit into
LTCyogi:masterfrom
joshwegener:pr/04-hotkey-input-polish

Conversation

@joshwegener

@joshwegener joshwegener commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop recording when the trigger key is released, not only when modifiers change
  • allow keyCode 0 (A) to be stored as a valid hotkey
  • move keyboard injection off the main thread so long dictations do not stall the status item

Verification

  • swiftc -typecheck -target arm64-apple-macosx14.0 -sdk "$(xcrun --show-sdk-path)" -I include -I vendor/whisper.cpp/include -I vendor/whisper.cpp/ggml/include Sources/*.swift
  • ./build.sh

@LTCyogi

LTCyogi commented Apr 4, 2026

Copy link
Copy Markdown
Owner

Can you rebase this onto master?

@joshwegener
joshwegener force-pushed the pr/04-hotkey-input-polish branch from 6f4bbb5 to 793b2f5 Compare April 4, 2026 01:50
@joshwegener

Copy link
Copy Markdown
Contributor Author

Rebased onto current master and force-pushed the branch.

Conflicts are resolved, and I re-ran a local app build on the rebased branch:

  • ./build.sh

GitHub CI is now running on the updated head.

@LTCyogi
LTCyogi merged commit c80a3a1 into LTCyogi:master Apr 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants