Client streamable http #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What changed and why: - Built complete StreamableHttpClientTransport implementation following the MCP streamable HTTP specification - Added ClientStreamManager abstraction to handle multiple SSE streams per server with proper lifecycle management - Extended ClientTransport interface with close() method for explicit resource cleanup - Supports HTTP POST for message sending, SSE streams for responses, GET-based server-initiated streams, and session management Impact: - Client sessions can now connect to HTTP-based MCP servers - Handles complex streaming scenarios with background task management - Fully spec-compliant with proper error handling for session expiry and server capabilities
What changed and why: - Added abstract close() method to ServerTransport interface for explicit resource cleanup, matching the ClientTransport pattern - Implemented close() in StreamableHttpServerTransport to stop HTTP server and clean up sessions and streams - Updated ServerSession.disconnect_all_clients() to call transport.close() - Fixed stdio transport implementation to include close() method Impact: - Consistent transport interface between client and server sides - Proper resource cleanup when server sessions shut down completely - Prevents resource leaks in HTTP servers and other transport types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented complete streamable HTTP client transport from scratch following the MCP specification, plus added consistent
close()method to both client and server transport interfaces.Why?
We needed a robust HTTP transport implementation to enable client sessions to connect to HTTP-based MCP servers. The existing draft was incomplete and didn't handle the complex streaming scenarios required by the spec.
Impact
ClientStreamManagerabstraction with proper background task cleanupclose()methods for explicit resource cleanupTesting
Review notes
ClientStreamManagerabstraction cleanly handles multiple SSE streams per serverChecklist