Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Implemented complete OAuth 2.1 client authentication system for MCP servers in
src/conduit/auth/client/. This provides the foundation for secure MCP server authentication following the MCP authorization specification.Key components:
OAuth2Clientthat orchestrates the complete flowWhy?
The MCP specification requires OAuth 2.1 authentication for protected servers. Without this implementation, conduit-mcp cannot connect to secured MCP servers, limiting its utility in production environments where authentication is essential.
This follows the MCP auth specification's sequence: MCP request → 401 response → discovery → OAuth flow → authenticated requests.
Impact
For developers:
For the codebase:
Standards compliance:
Testing
All tests use the project's async testing patterns and follow the established testing conventions.
Review notes
stroverHttpUrlto avoid Pydantic normalization issues in OAuth flowsThe implementation prioritizes correctness and developer experience over brevity - OAuth is complex enough that clarity trumps conciseness.
Checklist