fix: expire stale auth challenges - #1438
Closed
silentgeckoaudit3801 wants to merge 1 commit into
Closed
Conversation
Contributor
|
thanks for the PR. this was a real bug when you branched, but the same fix already landed on main: authService already expires stale challenges and additionally handles clock skew, which this branch predates. since the change is now redundant, closing this one to keep the queue clean. please branch from current main before your next fix PR, and feel free to reopen if I misread anything. if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1320.
This PR fixes �ackend/src/services/authService.ts::verifyChallengeTimestamp so the freshness check compares elapsed age as
ow - timestamp instead of subtracting in the opposite direction.
The existing �uthService unit coverage already includes the replay boundary this restores: timestamps within the max-age window are accepted and timestamps older than the window are rejected.
Validation: static GitHub API/source inspection only; local backend tests were not run in this environment to avoid installing or executing additional toolchains.