Skip to content

fix(backend): require every granted scope #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bamiebot-maker wants to merge 1 commit into from
+20 −0
Closed

fix(backend): require every granted scope #1450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions backend/src/middleware/__tests__/jwtAuth.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,6 +273,26 @@ describe('jwtAuth middleware', () => {
);
});

it('should reject access when any one of multiple required scopes is missing', () => {
mockRequest.user = {
publicKey: 'GBORROWER',
role: 'borrower',
scopes: ['read:loans'],
iat: 1000,
exp: 2000,
};

const middleware = requireScopes('read:loans', 'write:repayment');

expect(() => middleware(mockRequest as Request, mockResponse as Response, mockNext)).toThrow(
expect.objectContaining({
statusCode: 403,
message: 'Missing required scope: write:repayment',
}),
);
expect(mockNext).not.toHaveBeenCalled();
});

it('should grant access when user has all required scopes', () => {
mockRequest.user = {
publicKey: 'GBORROWER',
Expand Down
Loading