Skip to content

fix: roundToCents uses Math.round instead of Math.floor to round to n… #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jotel-dev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: roundToCents uses Math.round instead of Math.floor to round to n… #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backend/src/controllers/loanController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
try {
const { loanId } = req.params;

const borrower = (req as any).user?.publicKey as string;

Check warning on line 55 in backend/src/controllers/loanController.ts

View workflow job for this annotation

GitHub Actions / backend 

Unexpected any. Specify a different type

const result = await query('SELECT * FROM loans WHERE id = $1', [loanId]);
const loan = result.rows[0] as Record<string, unknown> | undefined;
Expand Down Expand Up @@ -225,7 +225,7 @@
return result.rows[0]?.last_indexed_ledger ?? 0;
};

const roundToCents = (value: number): number => Math.floor((value + Number.EPSILON) * 100) / 100;
const roundToCents = (value: number): number => Math.round((value + Number.EPSILON) * 100) / 100;

const addDays = (date: Date, days: number): Date => {
const result = new Date(date);
Expand Down
Loading