fix(ui): remove unused clsx/twMerge imports from Input and Modal - #1454
Open
OpensrcLord wants to merge 1 commit into
Open
fix(ui): remove unused clsx/twMerge imports from Input and Modal#1454OpensrcLord wants to merge 1 commit into
OpensrcLord wants to merge 1 commit into
Conversation
Input.tsx and Modal.tsx imported clsx and tailwind-merge directly despite already using the shared cn() helper from @/app/utils/cn. These dead imports are now removed, completing the DRY cleanup started in commit 8210157 for Button, Card, and EmptyState. Closes LabsCrypt#1248
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the DRY cleanup from #1248.
Commit already replaced the local copies in Button, Card, and EmptyState with the shared import from . However, Input.tsx and Modal.tsx still carried dead
clsxandtwMergeimports — they imported the sharedcn()but never removed the raw dependencies they no longer use directly.This PR removes those unused imports so there are no dead symbols in the design-system folder.
Changes
clsxandtailwind-mergeimportsclsxandtailwind-mergeimportsVerification
cn()calls remain identicaltsc --noEmitpasses (pre-existing errors only, none from these files)closes #1248