fix(backend): requireLoanOwner IDOR — compare loan owner to caller - #1455
Merged
ogazboiz merged 2 commits intoJul 30, 2026
Merged
Conversation
…ests Clarify that requireLoanOwner compares the loan's stored owner address to the caller public key (not the caller to itself) and add unit coverage for the previous IDOR path. Closes LabsCrypt#1365 Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
TCROWN10
force-pushed
the
fix/1365-requireLoanOwner-idor-regression
branch
from
July 30, 2026 10:13
513e24a to
75147fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireLoanOwnerinbackend/src/middleware/loanAccess.tsso ownership checks compare the loan's stored owner (row.address) to the caller's JWT public key — not the caller key to itself (pk !== pk).Closes #1365
Test plan
npm test -- --testPathPatterns=loanAccess.test(5 passing)