feat(#1375): Scaffold OpNonce storage and batch validation logic - #1577
Open
T-kesh wants to merge 1 commit into
Open
feat(#1375): Scaffold OpNonce storage and batch validation logic#1577T-kesh wants to merge 1 commit into
T-kesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: closes #1375 (Phase 1).
The current smart contract lacks application-level nonces, making it vulnerable to replay attacks on already-applied operations when a fresh authorization is re-signed by the backend retry loop.
This PR introduces Phase 1 of the cross-layer fix for the Smart Contract infrastructure:
Scaffolds contracts/loan_manager/src/nonce.rs.
Introduces persistent monotonic OpNonce storage tracking.
Implements consume_nonce guard which bumps the counter strictly on stored + 1, blocking all downstream replays.
Adds valid_until_ledger batch window expiration checks.
Defines robust BatchError::NonceReused and BatchError::BatchWindowExpired handling.