Fix #1369: Add accrued interest instead of subtracting it - #1580
Open
T-kesh wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: closes #1369.
The getLoanDetails function in backend/src/controllers/loanController.ts contained a logic defect where accrued interest was being incorrectly subtracted from the total owed amount, rather than being added to it.
This PR corrects the calculation logic from: const totalOwed = principal - accruedInterest - totalRepaid; to const totalOwed = principal + accruedInterest - totalRepaid;
This ensures borrowers must properly pay accrued interest to fully repay their loan.