fix(ci): restore green main (prettier, cargo fmt, loan_events view migration) - #1583
Merged
Conversation
- backend: run prettier on crossContractReconciler.ts and its test (6 eslint errors) - contracts: cargo fmt on lending_pool/src/lib.rs - migrations: 1802000000000_money_stroops_integer failed on a fresh schema because the loan_events view depends on contract_events.amount and postgres refuses to retype a column a view uses. Drop the view before the ALTER and recreate it verbatim afterwards, in both up and down.
pgm.dropIndex(table, 'idx_...') treats the string as a column list and
generates the wrong index name (contract_events_idx_contract_events_seek_index),
so the rollback path failed once up() could complete. Pass the explicit
{ name } option instead.
deposit gained a min-shares arg, remittance_nft mint/update_score and metadata types changed shape. The fuzz crate is checked by CI but had drifted since these API changes landed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
Main CI has been red since ~July 30, which makes every contributor PR fail the backend, contracts and migration-check jobs through no fault of their own. This fixes the three causes:
src/services/crossContractReconciler.tsand its test.cargo fmtdiff inlending_pool/src/lib.rs.1802000000000_money_stroops_integerretypescontract_events.amount, but the backward-compatloan_eventsview depends on that column, so postgres aborts with "cannot alter type of a column used by a view or rule" on a fresh schema. The migration now drops the view before the ALTER and recreates it verbatim afterwards (up and down).Note: we also have two migrations sharing the number
1802000000000(create-ledger-checkpoints and money_stroops_integer). They run in a deterministic alphabetical order so nothing breaks today, but new migrations should start at1803000000000or higher.