Skip to content

feat: PWA support, collateral endpoints, get_proposed_admin, refinance/extend #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogazboiz merged 3 commits into from
May 27, 2026
Merged

feat: PWA support, collateral endpoints, get_proposed_admin, refinance/extend #914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7abeb2e
feat: PWA support, collateral endpoints, get_proposed_admin, refinanc…
ritik4ever May 27, 2026
ba22d60
fix: remove .unwrap() from accept_admin calls in contracts, update pa…
ritik4ever May 27, 2026
9a74ecd
fix: prettier formatting in backend and frontend files
ritik4ever May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
258 changes: 258 additions & 0 deletions backend/src/__tests__/loanEndpoints.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,38 @@ const mockBuildRepayTx =
amount: number,
) => Promise<{ unsignedTxXdr: string; networkPassphrase: string }>
>();
const mockBuildDepositCollateralTx =
jest.fn<
(
borrowerPublicKey: string,
loanId: number,
amount: number,
) => Promise<{ unsignedTxXdr: string; networkPassphrase: string }>
>();
const mockBuildReleaseCollateralTx =
jest.fn<
(
borrowerPublicKey: string,
loanId: number,
) => Promise<{ unsignedTxXdr: string; networkPassphrase: string }>
>();
const mockBuildRefinanceLoanTx =
jest.fn<
(
borrowerPublicKey: string,
loanId: number,
newAmount: number,
newTerm: number,
) => Promise<{ unsignedTxXdr: string; networkPassphrase: string }>
>();
const mockBuildExtendLoanTx =
jest.fn<
(
borrowerPublicKey: string,
loanId: number,
extraLedgers: number,
) => Promise<{ unsignedTxXdr: string; networkPassphrase: string }>
>();
const mockSubmitSignedTx =
jest.fn<
(
Expand All @@ -68,6 +100,10 @@ jest.unstable_mockModule("../services/sorobanService.js", () => ({
sorobanService: {
buildRequestLoanTx: mockBuildRequestLoanTx,
buildRepayTx: mockBuildRepayTx,
buildDepositCollateralTx: mockBuildDepositCollateralTx,
buildReleaseCollateralTx: mockBuildReleaseCollateralTx,
buildRefinanceLoanTx: mockBuildRefinanceLoanTx,
buildExtendLoanTx: mockBuildExtendLoanTx,
submitSignedTx: mockSubmitSignedTx,
},
}));
Expand Down Expand Up @@ -516,3 +552,225 @@ describe("POST /api/loans/:loanId/submit", () => {
expect(response.body.status).toBe("SUCCESS");
});
});

// ---------------------------------------------------------------------------
// POST /api/loans/:loanId/build-deposit-collateral
// ---------------------------------------------------------------------------
describe("POST /api/loans/:loanId/build-deposit-collateral", () => {
it("should reject unauthenticated requests", async () => {
const response = await request(app)
.post("/api/loans/1/build-deposit-collateral")
.send({ amount: 500, borrowerPublicKey: TEST_BORROWER });
expect(response.status).toBe(401);
});

it("should return unsigned XDR for valid deposit collateral", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

mockBuildDepositCollateralTx.mockResolvedValueOnce({
unsignedTxXdr: "CCCC...deposit-collateral-xdr",
networkPassphrase: "Test SDF Network ; September 2015",
});

const response = await request(app)
.post("/api/loans/1/build-deposit-collateral")
.set(bearer(TEST_BORROWER))
.send({ amount: 500, borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(200);
expect(response.body.success).toBe(true);
expect(response.body.loanId).toBe(1);
expect(response.body.unsignedTxXdr).toBe("CCCC...deposit-collateral-xdr");
});

it("should return 403 when loan does not belong to user", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: "other-wallet" }],
});

const response = await request(app)
.post("/api/loans/1/build-deposit-collateral")
.set(bearer(TEST_BORROWER))
.send({ amount: 500, borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(403);
});
});

// ---------------------------------------------------------------------------
// POST /api/loans/:loanId/build-release-collateral
// ---------------------------------------------------------------------------
describe("POST /api/loans/:loanId/build-release-collateral", () => {
it("should reject unauthenticated requests", async () => {
const response = await request(app)
.post("/api/loans/1/build-release-collateral")
.send({ borrowerPublicKey: TEST_BORROWER });
expect(response.status).toBe(401);
});

it("should return unsigned XDR for valid release collateral", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

mockBuildReleaseCollateralTx.mockResolvedValueOnce({
unsignedTxXdr: "DDDD...release-collateral-xdr",
networkPassphrase: "Test SDF Network ; September 2015",
});

const response = await request(app)
.post("/api/loans/1/build-release-collateral")
.set(bearer(TEST_BORROWER))
.send({ borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(200);
expect(response.body.success).toBe(true);
expect(response.body.loanId).toBe(1);
expect(response.body.unsignedTxXdr).toBe("DDDD...release-collateral-xdr");
});

it("should return 403 when loan does not belong to user", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: "other-wallet" }],
});

const response = await request(app)
.post("/api/loans/1/build-release-collateral")
.set(bearer(TEST_BORROWER))
.send({ borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(403);
});
});

// ---------------------------------------------------------------------------
// POST /api/loans/:loanId/build-refinance
// ---------------------------------------------------------------------------
describe("POST /api/loans/:loanId/build-refinance", () => {
it("should reject unauthenticated requests", async () => {
const response = await request(app)
.post("/api/loans/1/build-refinance")
.send({
newAmount: 2000,
newTerm: 34560,
borrowerPublicKey: TEST_BORROWER,
});
expect(response.status).toBe(401);
});

it("should return unsigned XDR for valid refinance", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

mockBuildRefinanceLoanTx.mockResolvedValueOnce({
unsignedTxXdr: "EEEE...refinance-xdr",
networkPassphrase: "Test SDF Network ; September 2015",
});

const response = await request(app)
.post("/api/loans/1/build-refinance")
.set(bearer(TEST_BORROWER))
.send({
newAmount: 2000,
newTerm: 34560,
borrowerPublicKey: TEST_BORROWER,
});

expect(response.status).toBe(200);
expect(response.body.success).toBe(true);
expect(response.body.loanId).toBe(1);
expect(response.body.unsignedTxXdr).toBe("EEEE...refinance-xdr");
});

it("should return 403 when loan does not belong to user", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: "other-wallet" }],
});

const response = await request(app)
.post("/api/loans/1/build-refinance")
.set(bearer(TEST_BORROWER))
.send({
newAmount: 2000,
newTerm: 34560,
borrowerPublicKey: TEST_BORROWER,
});

expect(response.status).toBe(403);
});

it("should reject missing newTerm", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

const response = await request(app)
.post("/api/loans/1/build-refinance")
.set(bearer(TEST_BORROWER))
.send({ newAmount: 2000, borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(400);
});
});

// ---------------------------------------------------------------------------
// POST /api/loans/:loanId/build-extend
// ---------------------------------------------------------------------------
describe("POST /api/loans/:loanId/build-extend", () => {
it("should reject unauthenticated requests", async () => {
const response = await request(app)
.post("/api/loans/1/build-extend")
.send({ extraLedgers: 8640, borrowerPublicKey: TEST_BORROWER });
expect(response.status).toBe(401);
});

it("should return unsigned XDR for valid extend", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

mockBuildExtendLoanTx.mockResolvedValueOnce({
unsignedTxXdr: "FFFF...extend-xdr",
networkPassphrase: "Test SDF Network ; September 2015",
});

const response = await request(app)
.post("/api/loans/1/build-extend")
.set(bearer(TEST_BORROWER))
.send({ extraLedgers: 8640, borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(200);
expect(response.body.success).toBe(true);
expect(response.body.loanId).toBe(1);
expect(response.body.unsignedTxXdr).toBe("FFFF...extend-xdr");
});

it("should return 403 when loan does not belong to user", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: "other-wallet" }],
});

const response = await request(app)
.post("/api/loans/1/build-extend")
.set(bearer(TEST_BORROWER))
.send({ extraLedgers: 8640, borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(403);
});

it("should reject missing extraLedgers", async () => {
mockedQuery.mockResolvedValueOnce({
rows: [{ address: TEST_BORROWER }],
});

const response = await request(app)
.post("/api/loans/1/build-extend")
.set(bearer(TEST_BORROWER))
.send({ borrowerPublicKey: TEST_BORROWER });

expect(response.status).toBe(400);
});
});
Loading
Loading