test: add coverage for assigned issues #902 and #903 - #916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #902
Closes #903
Closes #904
Closes #901
Assigned issues
[Testing] Add cross-contract fuzz target spanning LoanManager, LendingPool, and RemittanceNFT[Testing] Expand LoanManager liquidate test coverage to 6 distinct scenarios[Testing] Add integration test for full loan dispute resolution flow[Testing] Add migration-path tests for LoanManager and RemittanceNFT upgradeScope of this PR
This branch implements the two simplest assigned issues from the set above:
The remaining assigned issues are acknowledged here for tracking, but are not included in this branch:
Changes
LoanLiquidatedevent assertions.confirmandreverseactions.Testing
node --experimental-vm-modules node_modules/jest/bin/jest.js src/__tests__/integration/loanDisputeFlow.test.tscargois not installed on this machine.