LibWeb/HTML: Fix UTF-16BE/LE not converting to UTF-8 #3124
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaycadox
changed the title
Previously, the charset of name "UTF-16BE/LE" would be checked against when following standards to convert the charset to UTF-8, but in reality, the charsets "UTF-16BE" and "UTF-16LE" should be checked separately.
Jaycadox
force-pushed
the
utf8-fix-conversion
branch
from
fffdb5c to
65f2bd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The correct behavior is specified in the standard here. I believe the mistake was made when reading "If charset is UTF-16BE/LE, then set charset to UTF-8" in the standard document here.
Fixes 9 WPT tests.
I had wanted to import the WPT test, but as the entire test takes >30s to run (on my machine), I don't think that's really wanted. I can, however, create a small test just for this case if you'd like, but feel like it's quite niche.