LibWeb/XML: Set attributes using Element::set_attribute_ns #3138
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtkinsSJ
added a commit
to AtkinsSJ/ladybird
that referenced
this pull request
Jan 4, 2025
Parse a qualified name, and use the namespace when looking up the attribute. Also bring the spec comments up to date, as the syntax description has changed a bit. WIP: Waiting for LadybirdBrowser#3138 before the test will pass.
Otherwise we'd end up ignoring attr prefixes and treating them as part of the attribute's local name. Fixes LadybirdBrowser#3137. This is a partial revert of b3fdeef, but it fixes the underlying issue that it was working around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we'd end up ignoring attr prefixes and treating them as part of the attribute's local name.
Fixes #3137.