LibWeb: Return a representation of an 'Agent' in 'relevant agent' #3142
+140
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannonbooth
force-pushed
the
relevant-agent-cumbersome
branch
2 times, most recently
from
410f794 to
32c6262
Compare
shannonbooth
force-pushed
the
relevant-agent-cumbersome
branch
from
32c6262 to
b68b5f6
Compare
shannonbooth
commented
Jan 5, 2025
|
|
||
| // https://dom.spec.whatwg.org/#mutation-observer-list | ||
| // FIXME: This should be a set. | ||
| Vector<GC::Ref<DOM::MutationObserver>> mutation_observers; |
There was a problem hiding this comment.
Hmm, I think CI might be complaining from this not being visited? I'm not sure what makes this any different from a GC perspective though..? It was a Vector<GC:Ref<T>> beforehand, so not sure how this would become a problem now
There was a problem hiding this comment.
yeah that turned out to be the issue, wonder why it didnt come up before
shannonbooth
force-pushed
the
relevant-agent-cumbersome
branch
from
b68b5f6 to
3a776dc
Compare
This makes it more convenient to use the 'relvant agent' concept, instead of the awkward dynamic casts we needed to do for every call site. mutation_observers is also changed to hold a GC::Root instead of raw GC::Ptr. Somehow this was not causing problems before, but trips up CI after these changes.
shannonbooth
force-pushed
the
relevant-agent-cumbersome
branch
from
3a776dc to
8fd9f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more convenient to use the 'relvant agent' concept,
instead of the awkward dynamic casts we needed to do for every call
site.